Skip to content

ci: update OFED version to doca3.3.0-26.01-0.9.5.0.840-0#2640

Closed
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-0.9.5.0.840-0
Closed

ci: update OFED version to doca3.3.0-26.01-0.9.5.0.840-0#2640
nvidia-ci-cd wants to merge 1 commit into
masterfrom
ci/update-ofed-version-26.01-0.9.5.0.840-0

Conversation

@nvidia-ci-cd

Copy link
Copy Markdown
Collaborator

Created by an internal DOCA CI job.

Signed-off-by: svc-cloud-orch-ci <svc-cloud-orch-ci@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 6, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@greptile-apps

greptile-apps Bot commented Jun 6, 2026

Copy link
Copy Markdown

Greptile Summary

This automated PR from the internal DOCA CI job updates the OFED/DOCA driver version string across all example CRs and hack/release.yaml. The change is uniform across all 8 files, consistently replacing the old version with the new one.

  • Version change: doca3.4.0-26.04-0.8.6.0-0doca3.3.0-26.01-0.9.5.0.840-0 across 7 example NicClusterPolicy CRs and hack/release.yaml (both Mofed and MofedStigFips entries).
  • Staging registry: All files continue to point to nvcr.io/nvstaging/mellanox, which is consistent with the prior state and expected for example/CI resources.
  • Apparent downgrade: The new version string carries a lower DOCA major version (3.3.0 vs 3.4.0) and lower OFED version (26.01 vs 26.04), which may warrant confirmation that this reflects an intentional branch switch rather than an accidental rollback.

Confidence Score: 3/5

The change is a version string replacement that goes to a numerically lower DOCA and OFED version; merging without confirming the intent carries risk of shipping a downgraded driver.

Every changed file consistently replaces doca3.4.0-26.04-0.8.6.0-0 with doca3.3.0-26.01-0.9.5.0.840-0, which is a lower DOCA version (3.4.0 → 3.3.0) and a lower OFED version (26.04 → 26.01). While the automated CI job may be tracking a different, intentionally chosen release branch, the PR description provides no context to confirm this, making it impossible to distinguish an intentional branch switch from an accidental rollback.

hack/release.yaml is the most impactful file since it controls both Mofed and MofedStigFips release entries; the 7 example CRs mirror the same change uniformly.

Important Files Changed

Filename Overview
hack/release.yaml Updates Mofed and MofedStigFips driver versions from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.840-0 — a version downgrade in both DOCA and OFED numbering.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full-ocp.yaml OFED driver version updated to doca3.3.0-26.01-0.9.5.0.840-0 in the full OCP example CR.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-full.yaml OFED driver version updated to doca3.3.0-26.01-0.9.5.0.840-0 in the full example CR.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ipoib.yaml OFED driver version updated to doca3.3.0-26.01-0.9.5.0.840-0 in the IPoIB example CR.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-nvidia-ipam.yaml OFED driver version updated to doca3.3.0-26.01-0.9.5.0.840-0 in the NVIDIA IPAM example CR.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ocp-hostdev.yaml OFED driver version updated to doca3.3.0-26.01-0.9.5.0.840-0 in the OCP hostdev example CR.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr-ocp.yaml OFED driver version updated to doca3.3.0-26.01-0.9.5.0.840-0 in the OCP example CR.
example/crs/mellanox.com_v1alpha1_nicclusterpolicy_cr.yaml OFED driver version updated to doca3.3.0-26.01-0.9.5.0.840-0 in the base example CR.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[DOCA Internal CI Job] -->|triggers PR| B[Version Update]
    B --> C[hack/release.yaml\nMofed + MofedStigFips]
    B --> D[example/crs/*.yaml\n7 NicClusterPolicy CRs]
    C --> E[doca3.4.0-26.04-0.8.6.0-0\n→ doca3.3.0-26.01-0.9.5.0.840-0]
    D --> E
    E --> F[nvcr.io/nvstaging/mellanox\ndoca-driver image]
Loading

Reviews (1): Last reviewed commit: "ci: update OFED version to doca3.3.0-26...." | Re-trigger Greptile

Comment thread hack/release.yaml
Comment on lines 51 to 55
image: doca-driver
repository: nvcr.io/nvstaging/mellanox
version: doca3.4.0-26.04-0.8.6.0-0
version: doca3.3.0-26.01-0.9.5.0.840-0
MofedStigFips:
image: doca-driver-stig-fips

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Version appears to be a downgrade

The DOCA version is changing from doca3.4.0-26.04-0.8.6.0-0 to doca3.3.0-26.01-0.9.5.0.840-0, which is a step backward in both the DOCA major version (3.4.0 → 3.3.0) and the OFED version (26.04 → 26.01). If this is an intentional switch to a different (e.g., more stable) release branch rather than a rollback, a note in the PR description explaining the rationale would help reviewers confirm this is correct.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@rollandf rollandf closed this Jun 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants